Open
Conversation
Grayscale leaflet plugin modified to extend TileLayer.WMS Included in demo project
…o-labels Buildings style with correct zoom levels
symbol style will be kept, adapted to latest git version and PR properly before any other style attemps. Fresh mapserver-basemap will be taken after this commit
yjacolin
requested changes
Feb 9, 2022
| user='osm', | ||
| host='docker.for.mac.localhost', | ||
| port=5436, | ||
| user='nicolas', |
Collaborator
There was a problem hiding this comment.
could you revert this change?
| @@ -0,0 +1,113 @@ | |||
| #define PASTER(str) #str | |||
Collaborator
There was a problem hiding this comment.
This base mapfile is not linked to the symbols support, isn't?
Collaborator
|
@Nicolasribot thank you for you huge work on this. Unfortunatly this PR is too big and we can review it correctly. Could you split it in few part? Scripts, topobase and symbols at least? My browser failed to display diff file after "scripts". |
Author
|
Yes I will make the changes. |
…eration of GetCapabilities document [refactor] homogenized template map file indentation
Added new style for displaying housenumbers & sped up generation of GetCapabilties document
…'s clean target so they will be properly recreated by calling 'make clean && make'
…nal database view [fix] added missing placeholders for Makefile variables
Optimized rendering performance of symbol layers
…attached to building objects [refactor] hardened SQL statements in post-symbols.sql.in [refactor] optimized database structure for faster queries on symbol and housenumber tables
…bility and causing massive performance issue on lower zoom levels
included address information attached to buildings in imposm import mapping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cleaning of a work started some years ago to support a style displaying symbols.
Symbol icons are based on OSM icons converted from SVG.
This style can be combined with other styles to add icons.
WIP: labels at z18, more properties should be defined in generate_styles.py to control symbols behaviour. Some symbols are missing (parking built from ways for instance).
Some examples of the style: https://github.com/Nicolasribot/basemaps/blob/master/README.md